in this assignment we had to take two pictures showing proper frames, edges & negative space. When showing these three things you want to give your subject space, so not giving your subject space is not right.
in this picture, its showing negative space, edges and frames because its not giving the sign enough room
in this picture, its giving the sign more space and better frames